-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve MyPy errors in Cosmos pre-commit #377
Conversation
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 91.26% 91.21% -0.05%
==========================================
Files 46 46
Lines 1579 1605 +26
==========================================
+ Hits 1441 1464 +23
- Misses 138 141 +3
☔ View full report in Codecov by Sentry. |
89d9644
to
8e01a6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very mich, @abhi12mohan ! It's looking very good. It's a relief to have the type checks in place. I left some minor comments in-line.
d68d3e7
to
7a3c3dc
Compare
@abhi12mohan, thank you very much for addressing the feedback and creating #382 to follow up on the issues that were ignored in this initial support to MyPy. Once we rebase and resolve the conflicts, we can merge this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @abhi12mohan , one last comment - and we can merge! 🎉
Description
Resolves all MyPy pre-commit errors. "type: ignore" comments used sparingly and only when needed, i.e. a MyPy solution currently does not exist or deeper code changes need to be made.
Closes: #301
Checklist